Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loading and exclude query issues with authors/roles #552

Merged
merged 6 commits into from
May 30, 2014

Conversation

frankiejarrett
Copy link
Contributor

Fixes #527
Fixes #551

/cc @shadyvb Please review

@frankiejarrett
Copy link
Contributor Author

@shadyvb @lukecarbis Would be great to get one of you to review and test this today. I'd like to get it into the next release, if possible.

@lukecarbis
Copy link
Contributor

Code looks great. I'm still have problems getting Stream to respect my Administrator exclude rule. These screenshots are from multisite, but single site installs have the same issue.

schermata 2014-05-30 alle 08 32 47 am
I double checked that I'm an administrator.

schermata 2014-05-30 alle 08 33 17 am
I double checked that my exclude rules included the Administrator user role.

schermata 2014-05-30 alle 08 34 07 am
Stream still tracks actions that I make.


I've just done some additional testing, and it seems like it doesn't even respect the user exclude setting (as opposed to the user role, above).

@frankiejarrett
Copy link
Contributor Author

@lukecarbis OK I found the problem and it's caused by the change introduced in #532 where the priority of connectors loading was set to 9 instead of 10. So the connectors class is loaded before WP_Stream_Settings::$options is even available! Investigating a workaround now...

@frankiejarrett
Copy link
Contributor Author

@lukecarbis OK, that should do it. Please confirm.

@lukecarbis
Copy link
Contributor

It works!

lukecarbis added a commit that referenced this pull request May 30, 2014
Fix loading and exclude query issues with authors/roles
@lukecarbis lukecarbis merged commit df3edba into develop May 30, 2014
@lukecarbis lukecarbis deleted the fix-exclude-authors-roles branch May 30, 2014 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stream settings exclude error for big wp_users table Excluding roles is not handled properly
2 participants