Issue 497: Abstracting Storage API #555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new WPDB Storage Adapter, instruct Stream to use it Provide a filtering mechanism to alter storage engine used
… for columns in MySQL
Execute the following to get a mongo server working inside vvv for testing:
```
vasshin # ssh into vagrant
sudo apt-get install mongodb -y
sudo pecl install mongo
echo 'extension=mongo.so' | sudo tee -a /etc/php5/mods-available/mongo.conf
sudo php5enmod mongo
sudo service php-fpm restart
```
You'll need to install a mu-plugin so the db engine would switch, put the
following in `mu-plugins/stream-mongo.php` ( or any filename ):
```
<?php
add_filter( 'wp_stream_db_adapter', function() { return 'mongo'; } );
add_filter( 'wp_stream_no_tables', '__return_true' );
```
|
@lukecarbis @fjarrett And now that Travis is finally happy, please do review/test at will. |
|
@fjarrett Please note that I'm now using WordPress:core ruleset for PHPCS checks, feel free to add extra rules to |
Conflicts: bin/.travis.yml includes/db.php includes/db/install/wpdb.php phpcs.ruleset.xml stream.php tests/bootstrap.php
…temporarily untill JetStream enables Facets feature
Conflicts: classes/class-wp-stream-context-query.php classes/class-wp-stream-dashboard-widget.php classes/class-wp-stream-db.php classes/class-wp-stream-install.php classes/class-wp-stream-query.php includes/db/install/wpdb.php includes/install.php stream.php tests/tests/test-stream.php
|
What shall we do about the
|
|
@lukecarbis I'd say option #1, except db-updates should remain in the includes dir because it's not a class. We might even be able to delete it completely. |
|
I'm happy with this branch now 😺. @shadyvb - any reason for us to keep the 'do not merge' tag? |
frankiejarrett
added a commit
that referenced
this pull request
Jun 10, 2014
Issue 497: Abstracting Storage API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #497
Remaining:
See #497 for further discussion.