Add support for mercator domain mapping plugin #993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any chance this gets merged / review |
|
LGTM! Also check https://github.com/xwp/stream/blob/develop/connectors/class-connector-edd.php#L350 for how Stream dealt with very similar actions like the ones here, essentially where |
shadyvb
approved these changes
Dec 19, 2018
|
I looked at a custom connector, but as mercator WordPress drop-in, there were issues around order of loading. I am using a custom connector right now, so I am using in production right now. Just thought I would share the code with XWP. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mercator is a popular domain mapping plugin rewritten by Human made. This plugin is used by a number of VIP GO / high scale projects. This drop-in, should be logged by stream as well.