Skip to content
This repository has been archived by the owner on Dec 16, 2022. It is now read-only.

Use plugins_url() directly #133

Merged
merged 1 commit into from
May 10, 2016

Conversation

danielbachhuber
Copy link
Contributor

This permits filtering of the final URL, which lets me use this plugin as a Git submodule without defining SCRIPT_DEBUG

This permits filtering of the final URL, which lets me use this plugin as a Git submodule without defining `SCRIPT_DEBUG`
@westonruter westonruter merged commit 25f0458 into xwp:develop May 10, 2016
@westonruter
Copy link
Contributor

@danielbachhuber why not use Composer with WordPress Packagist instead? This would then include compiled and minified JS. Eventually if we use Browserify, using a submodule won't be an option.

@danielbachhuber danielbachhuber deleted the use-plugins-url-directly branch May 11, 2016 19:31
@danielbachhuber
Copy link
Contributor Author

why not use Composer with WordPress Packagist instead?

Because I'm managing dependencies with Git submodules. Also, I like the option to be able to easily contribute back while I'm working on the project.

@westonruter
Copy link
Contributor

OK, cool. But then eventually you'd need to run grunt build anyway if we do any Browserify compilation, right?

@danielbachhuber
Copy link
Contributor Author

But then eventually you'd need to run grunt build anyway if we do any Browserify compilation, right?

Well, this would break my use of the project completely. My preference would be that you always commit a built copy of the assets to the repo.

@westonruter
Copy link
Contributor

@danielbachhuber You may not need to filter your script and style URLs anymore due to #249

@danielbachhuber
Copy link
Contributor Author

Cool, thanks for the heads up 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants