Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

URLs to minified files should respect the protocol #50

Open
gnotaras opened this issue Dec 19, 2013 · 3 comments
Open

URLs to minified files should respect the protocol #50

gnotaras opened this issue Dec 19, 2013 · 3 comments

Comments

@gnotaras
Copy link

When the user visits the web page over SSL, the URLs to minified styles/scripts use the http protocol instead of https.
@gnotaras
Copy link
Author

I'm not 100% sure that this is a problem with the plugin. It needs more testing. I'll report back at some later time.

@lkraav
Copy link

lkraav commented Apr 25, 2014

I'm pretty sure I'm seeing this. I would like the plugin rewrite all minified URL resources with protocol-relative "//" and be done with this issue. Looking into patching it.

lkraav pushed a commit to lkraav/wp-dependency-minification that referenced this issue Apr 25, 2014
output protocol-relative links for minify endpoints, fixes xwp#50
02419a1 
we are currently using get_option( "home" ) to build the $src address.
wordpress does not support protocol relative home address still as of 3.9,
see https://core.trac.wordpress.org/ticket/21153
lkraav pushed a commit to lkraav/wp-dependency-minification that referenced this issue Apr 25, 2014
Protocol-relative links for minify endpoints, fixes xwp#50
b2aff55 
we are currently using get_option( "home" ) to build the $src address.
wordpress does not support protocol relative home address still as of 3.9,
see https://core.trac.wordpress.org/ticket/21153
@lkraav
Copy link

lkraav commented Apr 25, 2014

Pull request commit is running on a live server and appears to be behaving nicely. I don't see any drawbacks.

http://www.paulirish.com/2010/the-protocol-relative-url/

lkraav pushed a commit to lkraav/wp-dependency-minification that referenced this issue Apr 25, 2014
Protocol-relative links for minify endpoints, fixes xwp#50
753d771 
we are currently using get_option( "home" ) to build the $src address.
wordpress does not support protocol relative home address still as of 3.9,
see https://core.trac.wordpress.org/ticket/21153
This was referenced Jul 29, 2014
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lkraav @gnotaras