Skip to content
This repository has been archived by the owner on Nov 10, 2022. It is now read-only.

Introduce .ci-config.sh to override Travis and pre-commit defaults #30

Closed
5 of 6 tasks
westonruter opened this issue Jan 15, 2014 · 2 comments
Closed
5 of 6 tasks

Introduce .ci-config.sh to override Travis and pre-commit defaults #30

westonruter opened this issue Jan 15, 2014 · 2 comments
Labels
enhancement

Comments

@westonruter
Copy link
Contributor

There should be a .ci-config.sh (or something) which exports various Bash variables which can be read-in by .travis.yml and bin/pre-commit.These variables can control things like:

  • Allow readme syncing to be disabled (Allow readme syncing to be disabled #28)
  • Where to fetch PHP_CodeSniffer from (also should grab from GitHub instead of Pear), and which branch or tag to use.
  • Where to fetch WordPress Coding Standards from, and which branch/tag/commit to use.
  • Path to phpunit.xml
  • Path to PHPCS ruleset XML file.
  • URL for Travis build button (for generate-markdown-readme), instead of pulling from the git remote

Others?
westonruter referenced this issue in xwp/stream Jan 15, 2014
@frankiejarrett
Revert "Use phpcs ruleset from bin"
c3afa74 
This reverts commit 03aebbd.
westonruter added a commit to xwp/stream that referenced this issue Apr 17, 2014
@westonruter
Allow PHPCS and WPCS to pull from different locations
6ba3888 
 * Point to expirimental PHPCS and WPCS for rulset subsets
 * Introduce config file for managing Travis before_script environment
 * Remove phpcs.ruleset.xml since we're referencing a core ruleset

See xwp/wp-dev-lib#30
westonruter added a commit that referenced this issue May 1, 2014
@westonruter
Allow PHPCS and WPCS to pull from different locations
fb5d1cc 
 * Point to expirimental PHPCS and WPCS for rulset subsets
 * Introduce config file for managing Travis before_script environment
 * Remove phpcs.ruleset.xml since we're referencing a core ruleset

See #30
westonruter added a commit to xwp/stream that referenced this issue May 1, 2014
@westonruter
Allow PHPCS and WPCS to pull from different locations
e9816c2 
 * Point to expirimental PHPCS and WPCS for rulset subsets
 * Introduce config file for managing Travis before_script environment
 * Remove phpcs.ruleset.xml since we're referencing a core ruleset

See xwp/wp-dev-lib#30
@westonruter westonruter mentioned this issue May 1, 2014
Merged
@JDGrimes
Copy link
Contributor

JDGrimes commented Dec 8, 2014

2 and 3 are fixed by #35. I'm not sure if 4 and 5 are possible yet or not.

@westonruter westonruter mentioned this issue Jan 16, 2016
Merged
@westonruter
Copy link
Contributor Author

In #127 the config file is .dev-lib called, but it can also be .ci-env.sh

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@westonruter @JDGrimes