Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Initial commit of stylesheets #4

Merged
merged 6 commits into from
Mar 28, 2014
Merged

Initial commit of stylesheets #4

merged 6 commits into from
Mar 28, 2014

Conversation

johnregan3
Copy link
Contributor

LESS/SCSS/CSS files and icon sprites.

cc/ @fjarrett

border: 1px solid #ddd;
-webkit-border-radius: 0;
-moz-border-radius: 0;
border-radius: 0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@johnregan3 Some indention is done with tabs and some with spaces. I think everything should be tabbed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fjarrett My bad. That was the output from my compliler.

@frankiejarrett
Copy link
Contributor

@johnregan3 Awesome. So now I think it would make sense to use variables somehow n the LESS/Sass files for the different color types (e.g. base-color, highlight-color, etc.)

See https://github.com/WordPress/WordPress/blob/master/wp-admin/css/colors/blue/colors.scss

/cc @mikexhtml for your expertise here if you have some spare time

@johnregan3
Copy link
Contributor Author

@fjarrett Oh Snap! That's pretty sweet. I didn't know you could use SASS like that, as far as using variables in imported stylesheets. I'll look into this.

@johnregan3
Copy link
Contributor Author

The LESS file structure had to be modified because the variables behave like constants and are overwritten by the last declaration of them, regardless if they appear in the imported file or not.

See less/less.js#297

@johnregan3
Copy link
Contributor Author

@fjarrett Ready for review.

johnregan3 added a commit that referenced this pull request Mar 28, 2014
Initial commit of stylesheets
@johnregan3 johnregan3 merged commit 1cd4f8e into master Mar 28, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants