Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance/fix_readme_code_sample #82

Merged
merged 1 commit into from
Jan 11, 2024
Merged

enhance/fix_readme_code_sample #82

merged 1 commit into from
Jan 11, 2024

Conversation

ranger163
Copy link
Contributor

  • Fix code sample in the readme file, as refactoring of kstore-file api has changed storeOf() function parameter from filePath:String to file:Path

@ranger163
enhance/fix_readme_code_sample
dc656ec 
- Fix code sample in the readme file, as refactoring of kstore-file api has changed storeOf() function parameter from filePath:String to file:Path
@ranger163 ranger163 marked this pull request as draft December 25, 2023 12:34
@ranger163 ranger163 marked this pull request as ready for review December 25, 2023 12:34
@ranger163
Copy link
Contributor Author

Hi @xxfast Please, find this readme update, as I can't edit the Reviewers section and add you as a reviewer.

xxfast
xxfast approved these changes Dec 26, 2023
View reviewed changes
Copy link
Owner

@xxfast xxfast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution 👍

@xxfast xxfast merged commit be6a1d9 into xxfast:master Jan 11, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xxfast xxfast xxfast approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ranger163 @xxfast