Use pointer to the container for int_vector_buffer iterator #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using reference member prevents defining assignment operator for the iterator class of int_vector_buffer. This commit fixes issue vgteam/sdsl-lite#436.
eseiler
approved these changes
Sep 11, 2023
|
Thank you for the PR!
It was removed quite a while ago: 8054784 The reason seems to have been that move/copy assignment works just as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using reference member prevents defining assignment operator for the iterator class of
int_vector_buffer. This commit fixes issue simongog#436 (the same PR is still open in Simon's fork but it is merged in vgteam's fork).On a completely different note, I noticed that the assign interface functions (in
utils.hpp) are removed (I mean these functions). Is there any specific reason why they are removed?