update smart.go #238
Merged
update smart.go #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@xxxserxxx any chance you can look at this bugfix? |
|
Thanks; sorry for the delay -- this one slipped by me. Do you know of any specific issues reported in gotop that are affected by this?
The darwin and FreeBSD are, as always, difficult for me to test, but I'll build a release candidate for testers. |
|
note that smart.go library supports temperature reading from nvmes at MacOSX so #240 should really work with the latest updates. And if not, then a bug should be filed to anatol/smart.go #230 and #170 are fixed by the previous smart.go updates. The bugs are fixed now. #143 is a CPU temperature and unrelated to smart.go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes issue with reading temps from SSDs and HDDs as described here: anatol/smart.go#7