refactor(renderer): show error when no width or height is set #196

xyflow · May 11, 2020 · 6dcb9f5 · 6dcb9f5
1 parent 7a2bff2
commit 6dcb9f5
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/src/container/GraphView/index.tsx b/src/container/GraphView/index.tsx
@@ -89,6 +89,11 @@ const GraphView = memo(
       }
 
       const size = getDimensions(rendererNode.current);
+
+      if (size.height === 0 || size.width === 0) {
+        throw new Error('The React Flow parent container needs a width and a height to render the graph.');
+      }
+
       updateSize(size);
     };
 

diff --git a/src/container/ReactFlow/index.tsx b/src/container/ReactFlow/index.tsx
@@ -49,7 +49,7 @@ export interface ReactFlowProps extends Omit<HTMLAttributes<HTMLDivElement>, 'on
 const ReactFlow = ({
   style,
   onElementClick,
-  elements,
+  elements = [],
   children,
   nodeTypes,
   edgeTypes,