Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(types): accepts readonly arrays in props #4456

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pcorpet
Copy link

@pcorpet pcorpet commented Jul 16, 2024

The library never modifies the arrays of nodes and edges given in properties, so we can accept readonly arrays.

Copy link

changeset-bot bot commented Jul 16, 2024

⚠️ No Changeset found

Latest commit: 01ec07b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@peterkogo
Copy link
Member

peterkogo commented Jul 24, 2024

Thanks for the PR! Unwanted mutations would be successfully prevented by this. However, we will have to check what implications this has in the grand scheme of things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants