Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ita translate error #91

Closed
kirkoff71 opened this issue Jul 14, 2024 · 10 comments
Closed

Ita translate error #91

kirkoff71 opened this issue Jul 14, 2024 · 10 comments

Comments

@kirkoff71
Copy link
Contributor

kirkoff71 commented Jul 14, 2024 •
edited
Loading

Are present error italian translate...
If do you want I can contribute.
Thanks
@kirkoff71 kirkoff71 changed the title Ita translate Ita translate error Jul 14, 2024
@kirkoff71
Copy link
Contributor Author

Found and correct the "it.json"

@xyzroe
Copy link
Owner

xyzroe commented Jul 15, 2024

Please make a PR with your contribution.

@kirkoff71
Copy link
Contributor Author

Just made yesterday.
🙂

@xyzroe
Copy link
Owner

xyzroe commented Jul 15, 2024

Just made yesterday. 🙂

No. Please check twice. Every Italian will say Grazie to you.
Screenshot 2024-07-16 at 1 02 41 AM
Screenshot 2024-07-16 at 1 02 45 AM

@xyzroe
Copy link
Owner

xyzroe commented Jul 15, 2024

I found you repository. You made new branch - super. Now you need to make pull request to push changes from your repository to this one.

@kirkoff71
Copy link
Contributor Author

Now I make... check if is ok.
Thanks for your work :)

@xyzroe
Copy link
Owner

xyzroe commented Jul 16, 2024

I still don't have any PRs

@xyzroe
Copy link
Owner

xyzroe commented Jul 16, 2024 •
edited
Loading

You have merged branch patch-1 with main one but only in you repo. But you need just to open new pull request from you branch patch-1 to this repository main branch.
If you open this repo main page in your browser GitHub will offer you to make a contribution using pull request.

@kirkoff71
Copy link
Contributor Author

kirkoff71 commented Jul 16, 2024 •
edited
Loading

Now you see?
If no, I attachment the file in this chat now
it.json

@xyzroe
Copy link
Owner

xyzroe commented Jul 16, 2024

when you create a PR it will be visible not only to me or you, but to everyone. I believe you can do it.

@xyzroe xyzroe mentioned this issue Jul 16, 2024
Merged
xyzroe added a commit that referenced this issue Jul 16, 2024
@xyzroe
Merge pull request #95 from kirkoff71/main
999c106 
Ita translate error #91
@xyzroe xyzroe closed this as completed Jul 16, 2024
xyzroe added a commit that referenced this issue Sep 14, 2024
@xyzroe
20240914
cb8a4af 
        - Add option to disable CRON firmware check (#108, #104, #99, #88)
- Little mistake in french translation on the status page #107 Thanks @alainvdu69 🏆
- web.cpp cleanup #97 Thanks @Bixkitts 🏆
- Ita translate error #91 Thanks @kirkoff71 🏆
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xyzroe @kirkoff71