-
Notifications
You must be signed in to change notification settings - Fork 88
Added app shortcut to instantly launch game #24
base: master
Are you sure you want to change the base?
Conversation
Are those "imports" useless and needed to be removed? |
@licaon-kter Yeah, Android Studio removed them automatically, so I guess that they are not needed anymore. |
Is there a reason this is a dynamic shortcut instead of a static one? It seems the same functionality could be implemented with a static shortcut, as in https://developer.android.com/guide/topics/ui/shortcuts/creating-shortcuts#static |
I totally forgot about static shortcuts. I'll rewrite this later today. Thanks |
@xyzz I've changed it to static. |
The shortcut working in debug would be nice to have but not overly important. However, the current implementation won't work for |
@xyzz While adding shortcuts to nightly I've decided to add them to debug as well. Sorry for a long delay on this PR 😉 |
Hmm, I've tried it out again, and a problem it introduces is that if you run the game, then minimize and run again through the shortcut, it is restarted instead of resumed. I suspect this shouldn't be how it's supposed to work, can you confirm? |
Hi @xyzz great work on android version of OpenMW. I've wanted to help and resolve #21
It goes without saying that its more of a POC and not a final implementation, would love some pointers from you about, naming, code and shortcut appearance.