replace malloc/strcpy pair with strdup to allocate correct size

xyzz · Apr 11, 2019 · 79e63a8 · 79e63a8
1 parent aedcc25
commit 79e63a8
Showing 1 changed file with 2 additions and 5 deletions.
diff --git a/libgamestream/xml.c b/libgamestream/xml.c
@@ -118,11 +118,8 @@ static void XMLCALL _xml_start_status_element(void *userData, const char *name,
     for (int i = 0; atts[i]; i += 2) {
       if (strcmp("status_code", atts[i]) == 0)
         *status = atoi(atts[i + 1]);
-      else if (*status != STATUS_OK && strcmp("status_message", atts[i]) == 0) {
-        gs_error = malloc(strlen(atts[i + 1]));
-        if (gs_error)
-          strcpy((char*) gs_error, atts[i + 1]);
-      }
+      else if (*status != STATUS_OK && strcmp("status_message", atts[i]) == 0)
+        gs_error = strdup(atts[i + 1]);
     }
   }
 }