Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Display streaming FPS" option #167

Closed
wants to merge 14 commits into from
Closed

Add "Display streaming FPS" option #167

wants to merge 14 commits into from

Conversation

MakiseKurisu
Copy link

Currently the streaming FPS option is defined at build time. This PR aims to make this an end-user changeable option.
I'm currently working on display scaling for 21:9 host resolution, so I'm intended to add more diagnostic info to this feature later.

Alternative to this is to use sceRegMgrGetKeyInt (see xyzz/vita-button-swapper). However this requires extended permission.
The default font cannot display ◯.  Currently every call to draw_alert will have buttons_count either 0 or 1. Thus we can leave the other 2 alone for now.
... that it's only about the streaming fps, not the host fps
@mirh
Copy link

mirh commented Apr 27, 2020

This is cool, but what kind of decent scaling could you even achieve between different aspect ratios?
Unless you are talking about proper 21:9 with the right fov, and scaling means pan and scan?

@MakiseKurisu
Copy link
Author

MakiseKurisu commented Apr 27, 2020

The issue with 21:9 host monitor is two fold:

  1. when host is running in 21:9 resolution, Moonlight will display a squeezed image on Vita's 16:9 display. In this case we need to squeeze the image again to add black bars on the top and bottom. As a bonus we can use the black bar to display extra info (fps, touchscreen special keys, ping, etc)
  2. when host changes to a 16:9 resolution, Moonlight will still show a 21:9 squeezed image, with black bars on the left and right. In this case we need to desqueeze it.

When I say scaling I'm really talking about squeezing and desqueezing, and this can be done by replacing vita2d_draw_texture with vita2d_draw_texture_scale. Currently Moonlight will redraw menu in the black bar area, so I need to figure out how to disable that part of code during streaming.

MakiseKurisu and others added 2 commits April 26, 2020 20:18
@d3m3vilurr
Copy link
Collaborator

could you rebase it?

@MakiseKurisu
Copy link
Author

Alright I think that's it. This is the first time for me to do a rebase from command line, so hopefully I didn't mess anything up.

@d3m3vilurr
Copy link
Collaborator

pretty mess, but it's okay. i'll squash these commits ;)

@d3m3vilurr
Copy link
Collaborator

9f27692

@d3m3vilurr d3m3vilurr closed this Apr 27, 2020
@MakiseKurisu MakiseKurisu deleted the ShowFPS branch April 27, 2020 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants