Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pairing issue #231

Closed
wants to merge 405 commits into from
Closed

Fix pairing issue #231

wants to merge 405 commits into from

Conversation

Fewnity
Copy link

@Fewnity Fewnity commented Apr 26, 2023

I hope it's ok this time! I've added the history of commits and I haven't touched the code style.

Libgamestream is now up to date, I've fixed compilation errors caused by the update, and I've added the patch to Libgamestream to fix the pairing issue.

But with your last commit, Enet prevents pairing from occurring correctly, so we have to re-use the older version of Enet. But we can keep the last version of moonlight-common-c. (This pr does not revert Enet version).

To avoid you long scrolls in the history, here are my commits:
Update libgamestream: 8d457c4
Fix compilation: f812cf0
Fix pairing issue: 02035c9

darsto and others added 30 commits December 3, 2017 12:18
The previous code was probably a typo.
This patch doesn't bring any measurable
performance improvements, but still
prevents the fd from being corrupted.

Signed-off-by: Dariusz Stojaczyk <darek.stojaczyk@gmail.com>
Moonlight only uses libamcodec, make it depend only on it.
Edit of Contribution text for reading clarity.
This reverts commit f7fadbd.

On some systems libamcodec.so depends on libamadec.so or libamavutils.so
@d3m3vilurr
Copy link
Collaborator

ok. imo 02035c9 could be mergeable without any other commits.
so I'll pick it manually

then i'll check the other things(updating libgamestream of moonlight-embedded)

@d3m3vilurr
Copy link
Collaborator

your code was picked 5494d93

i think we don't need every patches of libgamestream that because moonlight-embedded's one have to support multiplatform.
but this repo is specialized platform version.

our vita newlib would support more posix functions than before, so i think, we can remove some specialized patches.
but i'll manually check 2019/05 ~ current commits of libgamestream :)
I'll open the this pr until finishing that job.

thank you for your contribution

@d3m3vilurr d3m3vilurr mentioned this pull request Apr 26, 2023
@d3m3vilurr
Copy link
Collaborator

it replaced to #232

@d3m3vilurr d3m3vilurr closed this Apr 26, 2023
@d3m3vilurr d3m3vilurr mentioned this pull request Apr 26, 2023
@Fewnity Fewnity deleted the fix-pairing branch April 26, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.