Fix server version parsing (non-numeric build) #117
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The server version handling code is assuming all version components are numeric, which isn't the case when the fourth component is a build tag (such as
12-stable-98abc83
). This causes an exception when connecting to servers.This PR keeps version components as a string when they can't be parsed as an integer (although I feel the proper course of action here would be returning the unparsed version in the tuple, and then use
distutils.version.LooseVersion
for comparisons inClickHouseDialect.initialize()
.