Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix server version parsing (non-numeric build) #117

Merged
merged 1 commit into from
Dec 29, 2020

Conversation

carlosefr
Copy link
Contributor

The server version handling code is assuming all version components are numeric, which isn't the case when the fourth component is a build tag (such as 12-stable-98abc83). This causes an exception when connecting to servers.

This PR keeps version components as a string when they can't be parsed as an integer (although I feel the proper course of action here would be returning the unparsed version in the tuple, and then use distutils.version.LooseVersion for comparisons in ClickHouseDialect.initialize().

@coveralls
Copy link

coveralls commented Dec 29, 2020

Coverage Status

Coverage remained the same at 95.511% when pulling 141c8c5 on carlosefr:fix_version_check into 676034c on xzkostyan:master.

@xzkostyan xzkostyan merged commit 3dd0e1f into xzkostyan:master Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants