Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add count(expr) #3

Merged
merged 2 commits into from
Jul 5, 2017
Merged

Add count(expr) #3

merged 2 commits into from
Jul 5, 2017

Conversation

gribanov-d
Copy link
Contributor

When you want to do COUNT(DISTINCT(column))

@xzkostyan
Copy link
Owner

Hi,

This PR looks like good feature. Please, add tests for COUNT() and COUNT(DISTINCT(column)) in tests/test_select.py. Without test this feature can be broken in the future.

@xzkostyan
Copy link
Owner

Please resolve conflicts: ClickHouseCompiler was moved from src/base.py to src/drivers/base.py.

@xzkostyan xzkostyan merged commit 2a22a60 into xzkostyan:master Jul 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gribanov-d @xzkostyan @dentaku7