-
-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTTP-session tests, assorted fixes #73
Conversation
Yes, you are right. Clickhouse-over-http is not obsolete. I want to made http transport in this project obsolete (not fully supported). I don't have enough efforts to maintain both transports. But PRs are always appreciated! If you are working with large datasets tcp transport is faster, than http. Types conversion object -> str or str -> object is main bottleneck. |
Best-case is you could at least avoid breaking it (thus the tests), worst-case – it will have to have the tests in a different fork, and PRs with fixes.
That's mostly the problem of the TSV parsing; another modification (intended for a next PR) is streamed JSONCompact parsing (also, see ClickHouse/ClickHouse#7841 ). |
I'll try to review PR by the end of this week. |
bump. |
I need a little more time for brief review of whole changes. I'll return with feedback asap. |
bump. |
clickhouse-over-HTTP is not obsolete.
This is a preliminary pull request; merging various improvements and fixes to upstream.