Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for LIMIT BY clause #97

Merged
merged 4 commits into from
Jun 19, 2020
Merged

Add support for LIMIT BY clause #97

merged 4 commits into from
Jun 19, 2020

Conversation

ods
Copy link
Contributor

@ods ods commented Jun 16, 2020

No description provided.

@coveralls
Copy link

coveralls commented Jun 16, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.07%) to 95.221% when pulling 5ad7f69 on ods:limit_by into 0ff0bee on xzkostyan:master.

@xzkostyan
Copy link
Owner

xzkostyan commented Jun 17, 2020 •
edited
Loading

flake8 is failed for Python < 3.5: https://travis-ci.org/github/xzkostyan/clickhouse-sqlalchemy/builds/698852034

xzkostyan
xzkostyan requested changes Jun 17, 2020
View reviewed changes
clickhouse_sqlalchemy/ext/clauses.py Outdated Show resolved Hide resolved
@ods ods requested a review from xzkostyan June 18, 2020 14:22
@xzkostyan xzkostyan merged commit 5890383 into xzkostyan:master Jun 19, 2020
@ods ods deleted the limit_by branch June 19, 2020 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xzkostyan xzkostyan xzkostyan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ods @coveralls @xzkostyan