pin wasm wheel runner to ubuntu-20.04 #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Example "release" set of actions over in my fork: https://github.com/kafonek/ypy/actions/runs/3735184567/jobs/6338130318 |
|
@kafonek Thanks for working this out. Seems like a good solution. |
Waidhoferj
approved these changes
Dec 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
ubuntu-latestresolves toubuntu-22.04, it fails to checkout Python 3.10.2 (https://github.com/y-crdt/ypy/actions/runs/3687267693/jobs/6240630198#step:3:10). I think it's best to try and build with 3.10.2 to match Pyodide. Workaround is to pin this task toubuntu-20.04runner, which works. Maybe a future Pyodide release will be built with a Python version that lines up withubuntu-22.04Python targets.