-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Ypy API for new Yrs version #16
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated libraries and adapted Ypy API to be more Pythonic. The goal of the latter is to make Y types as interoperable as possible with native Python data structures without causing confusion.
Changes
Package Updates
Rust Ypy methods:
trait Iterator
to several internal type iterators for clarityYTransaction
argument for all read-only functions.YArray
Added native support for:
[el for el in y_array]
el in y_array
y_array[0]
y_array[1:3]
[1,2,3]
and ReprYArray([1,2,3])
outputs for printing.len(y_array)
YMap
[key for key in y_map]
entries()
toitems()
to match Python dictionary APIkey in y_map
y_map["key"]
{"key": "value"}
and ReprYMap({"key": "value"})
outputs for printing.len(y_map)
YText
[c for c in y_text]
substring in y_text
"hello"
and ReprYText("hello")
outputs for printing.len(y_text)
I recommend adding character and range indexing in another PR. The other option would just be converting first and then operating on the string:
YXml Types
Made the following methods into getters:
Added String an Repr methods similar to the ones above.
Testing
Updated tests to handle new functionality
Documentation
Updated docstrings and type hints for all methods