Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix YDoc client_id type and name #17

Merged
merged 1 commit into from
Mar 21, 2022
Merged

Fix YDoc client_id type and name #17

merged 1 commit into from
Mar 21, 2022

Conversation

davidbrochart
Copy link
Collaborator

No description provided.

Waidhoferj
Waidhoferj approved these changes Mar 21, 2022
View reviewed changes
Copy link
Collaborator

@Waidhoferj Waidhoferj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I agree that client_id is much more descriptive.

@Waidhoferj Waidhoferj merged commit ab33a7e into y-crdt:main Mar 21, 2022
@davidbrochart
Copy link
Collaborator Author

I agree that client_id is much more descriptive.

Also to be coherent with Yjs, where it is clientID.

@davidbrochart davidbrochart deleted the ydoc_id branch March 21, 2022 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Waidhoferj Waidhoferj Waidhoferj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidbrochart @Waidhoferj