Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropped Subscription Id Causing unobserve to trigger #26

Merged
merged 1 commit into from
Apr 6, 2022
Merged

Dropped Subscription Id Causing unobserve to trigger #26

merged 1 commit into from
Apr 6, 2022

Conversation

Waidhoferj
Copy link
Collaborator

I added a test based on a variation of what was described in #23 . Could not reproduce the invalid behavior locally.

@Waidhoferj Waidhoferj self-assigned this Apr 4, 2022
@Waidhoferj Waidhoferj added the bug Something isn't working label Apr 4, 2022
@davidbrochart
Copy link
Collaborator

Could not reproduce the invalid behavior locally.

That was happening with v0.3.0, but it was fixed in main already.

@dmonad dmonad closed this Apr 5, 2022
@dmonad dmonad reopened this Apr 5, 2022
@Waidhoferj Waidhoferj marked this pull request as ready for review April 6, 2022 18:29
@Waidhoferj Waidhoferj merged commit dfa4828 into main Apr 6, 2022
@Waidhoferj Waidhoferj deleted the drop-sub-id branch April 6, 2022 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmonad dmonad dmonad approved these changes

@davidbrochart davidbrochart Awaiting requested review from davidbrochart

Assignees

@Waidhoferj Waidhoferj

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Waidhoferj @davidbrochart @dmonad