Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File Encryption in addFile Module #343

Merged
merged 9 commits into from
Jun 12, 2023
Merged

File Encryption in addFile Module #343

merged 9 commits into from
Jun 12, 2023

Conversation

y0014984
Copy link
Owner

@y0014984 y0014984 commented Mar 31, 2023

Merging this pull request will add an option to the addFile Eden Editor Module to directly encrypt the file content with the given encryption and key.

@y0014984 y0014984 self-assigned this Mar 31, 2023
@y0014984 y0014984 marked this pull request as ready for review March 31, 2023 12:18
@y0014984 y0014984 linked an issue Mar 31, 2023 that may be closed by this pull request
Copy link
Collaborator

@GermanHydrogen GermanHydrogen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The attribute section of the addFile module becomes a bit crowded.
It would be nice, if we could split that up, but I dont know if this is possible

addons/filesystem/stringtable.xml Show resolved Hide resolved
@y0014984
Copy link
Owner Author

New dependency: This PR needs to be changed to reflect changes made in this PR: #344

This adds an additional encryption method.

Copy link
Collaborator

@GermanHydrogen GermanHydrogen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@y0014984 y0014984 merged commit 28a1674 into dev Jun 12, 2023
@y0014984 y0014984 mentioned this pull request Jul 11, 2023
22 tasks
@y0014984 y0014984 mentioned this pull request Jul 26, 2023
18 tasks
@y0014984 y0014984 deleted the encrypted-files-in-editor branch July 26, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Allow creation of encrypted files directly in the eden editor
2 participants