Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: month view selection #57

Merged
merged 2 commits into from
Apr 22, 2020
Merged

fix: month view selection #57

merged 2 commits into from
Apr 22, 2020

Conversation

vilnytskyi
Copy link
Contributor

At the moment month selector is broken. The cause of issue is wrong computation of selected item's index based on current matrix row/column. This pull request fixes mentioned computation.

@codecov-io
Copy link

codecov-io commented Mar 24, 2020

Codecov Report

Merging #57 into dev will not change coverage by %.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               dev       #57   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           26        26           
  Lines          640       640           
  Branches        71        71           
=========================================
  Hits           640       640           
Impacted Files Coverage Δ
src/components/TableMatrixView.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 042930b...b0fac00. Read the comment docs.

@y0c y0c merged commit 4f3a147 into y0c:dev Apr 22, 2020
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (042930b) to head (b0fac00).
Report is 8 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##               dev       #57   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           26        26           
  Lines          640       640           
  Branches        71        71           
=========================================
  Hits           640       640           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants