Incremental Delivery Suggestions

.c8rc.json

@@ -4,6 +4,8 @@
   "exclude": [
     "src/**/index.ts",
     "src/**/*-fuzz.ts",
+    "src/execution/executorSchema.ts",
+    "src/overrides.d.ts",
     "src/jsutils/Maybe.ts",
     "src/jsutils/ObjMap.ts",
     "src/jsutils/PromiseOrValue.ts",

.changeset/config.json

@@ -0,0 +1,10 @@
+{
+  "$schema": "https://unpkg.com/@changesets/config@1.6.1/schema.json",
+  "changelog": "@changesets/cli/changelog",
+  "commit": false,
+  "linked": [],
+  "access": "restricted",
+  "baseBranch": "main",
+  "updateInternalDependencies": "patch",
+  "ignore": []
+}

.eslintrc.yml

@@ -154,7 +154,7 @@ rules:
   no-compare-neg-zero: error
   no-cond-assign: error
   no-console: warn
-  no-constant-condition: error
+  no-constant-condition: [error, { checkLoops: false }]
   no-control-regex: error
   no-debugger: warn
   no-dupe-args: error

.gitattributes

@@ -0,0 +1 @@
+* text=auto eol=lf

.github/CONTRIBUTING.md

@@ -1,4 +1,4 @@
-# Contributing to graphql-js
+# Contributing to graphql-executor
 
 We want to make contributing to this project as easy and transparent as
 possible. Hopefully this document makes the process for contributing clear and
@@ -13,35 +13,25 @@ issue. The best way is to provide a reduced test case on jsFiddle or jsBin.
 
 ## Pull Requests
 
-All active development of graphql-js happens on GitHub. We actively welcome
+All active development of graphql-executor happens on GitHub. We actively welcome
 your [pull requests](https://help.github.com/articles/creating-a-pull-request).
 
 ### Considered Changes
 
-Since graphql-js is a reference implementation of the
-[GraphQL spec](https://graphql.github.io/graphql-spec/), only changes which comply
-with this spec will be considered. If you have a change in mind which requires a
-change to the spec, please first open an
+Like graphql-js, graphql-executor is
+[GraphQL spec](https://graphql.github.io/graphql-spec/) compliant, so only changes
+which comply with this spec will be considered. If you have a change in mind which
+requires a change to the spec, please first open an
 [issue](https://github.com/graphql/graphql-spec/issues/) against the spec.
 
-### GraphQL Specification Membership Agreement
-
-This repository is managed by EasyCLA. Project participants must sign the free ([GraphQL Specification Membership agreement](https://preview-spec-membership.graphql.org) before making a contribution. You only need to do this one time, and it can be signed by [individual contributors](http://individual-spec-membership.graphql.org/) or their [employers](http://corporate-spec-membership.graphql.org/).
-
-To initiate the signature process please open a PR against this repo. The EasyCLA bot will block the merge if we still need a membership agreement from you.
-
-You can find [detailed information here](https://github.com/graphql/graphql-wg/tree/main/membership). If you have issues, please email [operations@graphql.org](mailto:operations@graphql.org).
-
-If your company benefits from GraphQL and you would like to provide essential financial support for the systems and people that power our community, please also consider membership in the [GraphQL Foundation](https://foundation.graphql.org/join).
-
 ### Getting Started
 
 1. Fork this repo by using the "Fork" button in the upper-right
 
 2. Check out your fork
 
    ```sh
-   git clone git@github.com:your_name_here/graphql-js.git
+   git clone git@github.com:your_name_here/graphql-executor.git
    ```
 
 3. Install or Update all dependencies
@@ -62,8 +52,9 @@ If your company benefits from GraphQL and you would like to provide essential fi
 
 ## Coding Style
 
-This project uses [Prettier](https://prettier.io/) for standard formatting. To
-ensure your pull request matches the style guides, run `npm run prettier`.
+Like graphql-js, this project uses [Prettier](https://prettier.io/) for standard
+formatting. To ensure your pull request matches the style guides, run
+`npm run prettier`.
 
 - 2 spaces for indentation (no tabs)
 - 80 character line length strongly preferred.
@@ -74,28 +65,7 @@ ensure your pull request matches the style guides, run `npm run prettier`.
 - Trailing commas,
 - Avd abbr wrds.
 
-## Release on NPM
-
-_Only core contributors may release to NPM._
-
-To release a new version on NPM, first ensure all tests pass with `npm test`,
-then use `npm version patch|minor|major` in order to increment the version in
-package.json and tag and commit a release. Then `git push && git push --tags`
-to sync this change with source control. Then `npm publish npmDist` to actually
-publish the release to NPM.
-Once published, add [release notes](https://github.com/graphql/graphql-js/tags).
-Use [semver](https://semver.org/) to determine which version part to increment.
-
-Example for a patch release:
-
-```sh
-npm test
-npm version patch
-git push --follow-tags
-npm publish npmDist
-```
-
 ## License
 
-By contributing to graphql-js, you agree that your contributions will be
+By contributing to graphql-executor, you agree that your contributions will be
 licensed under its [MIT license](../LICENSE).

.github/workflows/ci.yml

@@ -79,49 +79,6 @@ jobs:
       - name: Check that package-lock.json is in sync with package.json
         run: git diff --exit-code package-lock.json
 
-  integrationTests:
-    name: Run integration tests
-    runs-on: ubuntu-latest
-    steps:
-      - name: Checkout repo
-        uses: actions/checkout@v2
-        with:
-          persist-credentials: false
-
-      - name: Setup Node.js
-        uses: actions/setup-node@v2
-        with:
-          node-version: ${{ env.NODE_VERSION_USED_FOR_DEVELOPMENT }}
-          # We install bunch of packages during integration tests without locking them
-          # so we skip cache action to not pollute cache for other jobs.
-
-      - name: Install Dependencies
-        run: npm ci --ignore-scripts
-
-      - name: Run Integration Tests
-        run: npm run check:integrations
-
-  fuzz:
-    name: Run fuzzing tests
-    runs-on: ubuntu-latest
-    steps:
-      - name: Checkout repo
-        uses: actions/checkout@v2
-        with:
-          persist-credentials: false
-
-      - name: Setup Node.js
-        uses: actions/setup-node@v2
-        with:
-          cache: npm
-          node-version: ${{ env.NODE_VERSION_USED_FOR_DEVELOPMENT }}
-
-      - name: Install Dependencies
-        run: npm ci --ignore-scripts
-
-      - name: Run Tests
-        run: npm run fuzzonly
-
   coverage:
     name: Measure test coverage
     runs-on: ubuntu-latest
@@ -151,11 +108,12 @@ jobs:
           fail_ci_if_error: true
 
   test:
-    name: Run tests on Node v${{ matrix.node_version_to_setup }}
+    name: Test GraphQL v${{ matrix.graphql_version }} with Node v${{ matrix.node_version_to_setup }}
     runs-on: ubuntu-latest
     strategy:
       matrix:
         node_version_to_setup: [12, 14, 16, 17]
+        graphql_version: [14, 15, 16]
     steps:
       - name: Checkout repo
         uses: actions/checkout@v2
@@ -171,9 +129,37 @@ jobs:
       - name: Install Dependencies
         run: npm ci --ignore-scripts
 
+      - name: Force GraphQL Version
+        run: npm install graphql@${{ matrix.graphql_version }} --save=false
+
       - name: Run Tests
         run: npm run testonly
 
+  build:
+    name: Build with GraphQL v${{ matrix.graphql_version }}
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        graphql_version: [14, 15, 16]
+    steps:
+      - name: Checkout repo
+        uses: actions/checkout@v2
+
+      - name: Setup Node.js v${{ matrix.node_version_to_setup }}
+        uses: actions/setup-node@v2
+        with:
+          cache: npm
+          node-version: ${{ matrix.node_version_to_setup }}
+
+      - name: Install Dependencies
+        run: npm ci --ignore-scripts
+
+      - name: Force GraphQL Version
+        run: npm install graphql@${{ matrix.graphql_version }} --save=false
+
+      - name: Run Build
+        run: npm run build
+
   benchmark:
     name: Run benchmark
     runs-on: ubuntu-latest
@@ -240,9 +226,9 @@ jobs:
     runs-on: ubuntu-latest
     if: |
       github.event_name == 'push' &&
-      github.repository == 'graphql/graphql-js' &&
+      github.repository == 'yaacovCR/graphql-executor' &&
       github.ref == 'refs/heads/main'
-    needs: [test, fuzz, lint, checkForCommonlyIgnoredFiles, integrationTests]
+    needs: [test, lint, build, checkForCommonlyIgnoredFiles]
     steps:
       - name: Checkout repo
         uses: actions/checkout@v2
@@ -272,9 +258,9 @@ jobs:
     runs-on: ubuntu-latest
     if: |
       github.event_name == 'push' &&
-      github.repository == 'graphql/graphql-js' &&
+      github.repository == 'yaacovCR/graphql-executor' &&
       github.ref == 'refs/heads/main'
-    needs: [test, fuzz, lint, checkForCommonlyIgnoredFiles, integrationTests]
+    needs: [test, lint, build, checkForCommonlyIgnoredFiles]
     steps:
       - name: Checkout repo
         uses: actions/checkout@v2

.github/workflows/release.yml

@@ -0,0 +1,46 @@
+name: Release
+
+on:
+  push:
+    branches:
+      - main
+
+env:
+  NODE_VERSION_USED_FOR_DEVELOPMENT: 16
+jobs:
+  release:
+    name: Release
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout Repo
+        uses: actions/checkout@v2
+        with:
+          # This makes Actions fetch all Git history so that Changesets can generate changelogs with the correct commits
+          fetch-depth: 0
+          token: ${{ secrets.GITHUB_TOKEN }}
+
+      - name: Setup Node.js
+        uses: actions/setup-node@v2
+        with:
+          node-version: ${{ env.NODE_VERSION_USED_FOR_DEVELOPMENT }}
+
+      - name: Cache Node.js modules
+        uses: actions/cache@v2
+        with:
+          path: ~/.npm
+          key: ${{ runner.OS }}-node-${{ hashFiles('**/package-lock.json') }}
+          restore-keys: |
+            ${{ runner.OS }}-node-
+
+      - name: Install Dependencies
+        run: npm ci
+
+      - name: Create Release Pull Request or Publish to npm
+        id: changesets
+        uses: changesets/action@master
+        with:
+          version: npm run changeset:version
+          publish: npm run changeset:publish
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+          NPM_TOKEN: ${{ secrets.NPM_TOKEN }}