Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For saving time of other developers #20

Merged
merged 2 commits into from
Oct 24, 2022
Merged

Conversation

buzjuka
Copy link
Contributor

@buzjuka buzjuka commented Nov 16, 2021

No description provided.

@Envek
Copy link
Member

Envek commented Nov 16, 2021

Thank you for contribution!

I guess that you're not using Rails, right? Because for Ruby on Rails we have railtie that auto-configures Yabeda.
What is your stack? Maybe we can add some auto-configuration logic for some other frameworks also.

@buzjuka
Copy link
Contributor Author

buzjuka commented Nov 16, 2021

Hi. Thanks for response)
No)
I'm using RoR.
Maybe I missed some config lines or something else.
But
This is my environment

rails 5.2
puma 4.3.7
yabeda (0.11.0)

I have add these lines to my app

  # Gemfile.rb
  group :production, :staging do
    gem 'yabeda-puma-plugin'
    gem 'yabeda-prometheus-mmap'
  end
  
#config/puma.rb

activate_control_app
plugin :yabeda
plugin :yabeda_prometheus

And nothing. I have got blank response from metrics

After some research. I just add

# initializers/yabeda.rb
Yabeda.configure! if Rails.env.production? || Rails.env.staging?

Maybe this is bug related to using "single repo" pattern. I don't know.

But I think it could be helpfull for someone else)

@Envek
Copy link
Member

Envek commented Nov 16, 2021

That's really weird. It should be auto-configured. Thanks for providing details, I will take a look.

@ollym
Copy link
Contributor

ollym commented Dec 22, 2021

@Envek just to add, we had exactly the same issue. Rails 6.1 & Ruby 3.0

@hanyueitaro
Copy link

I had a similar problem.
I created the issue.
#21

@Envek Envek merged commit ffdaf0d into yabeda-rb:master Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants