Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status codes for unhandled exceptions #24

Merged
merged 1 commit into from
Jun 6, 2022

Conversation

dks17
Copy link
Contributor

@dks17 dks17 commented Jun 6, 2022

Encounted that Grafana did't show all status codes by requests as it should be. And the reason was that logs saved without no statuses if an exception was not handled properly, e.g.

{
  controller: "api/hello",
  action: "world",
  status: nil,
  format: :json,
  method: "get",
}

Some exceptions which will be handle automatically and codes. And example how it was made in Rails 7.

@Envek Envek merged commit 8f28c5e into yabeda-rb:master Jun 6, 2022
@Envek
Copy link
Member

Envek commented Jun 6, 2022

Awesome, thanks!

@Envek
Copy link
Member

Envek commented Jun 6, 2022

Released in 0.8.1

@dks17
Copy link
Contributor Author

dks17 commented Jun 6, 2022

@Envek Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants