Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when caret is at the end of blockquote and you press enter, create paragraph, not another blockquote #1162

Merged
merged 2 commits into from
Jul 30, 2016

Conversation

linkesch
Copy link
Member

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
New tests added? yes
Fixed tickets #294, #1054
License MIT

Description

We had this reported a bunch of times. When you place a caret at the end of a blockquote and press enter, a new blockquote is created instead of a plain paragraph and you have to press backspace to get rid of it. This is not a standard behavior. When you do the same with other block elements (h1, h2...) you will get a paragraph as expected. For some reason, this doesn't work with blockquotes.

Also when you try it in other "standard" editors (Word, Pages, Google Docs...), it behaves as expected - on enter you will get rid of the current "style" and start a new plain paragraph.

This PR solves this problem and forces a new paragraph after pressing enter at the end of a blockquote. Pressing enter anywhere else in the blockquote is not affected.

@coveralls
Copy link

coveralls commented Jul 28, 2016

Coverage Status

Coverage increased (+0.01%) to 94.986% when pulling e497496 on create-paragraph-on-enter-in-blockquote into 77e941a on master.

@nmielnik nmielnik merged commit 80356a4 into master Jul 30, 2016
This was referenced Jul 30, 2016
@j0k3r j0k3r deleted the create-paragraph-on-enter-in-blockquote branch August 1, 2016 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants