Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove src from bower ignored files #1330

Merged
merged 1 commit into from
May 9, 2017
Merged

remove src from bower ignored files #1330

merged 1 commit into from
May 9, 2017

Conversation

gsouf
Copy link
Contributor

@gsouf gsouf commented May 9, 2017

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
New tests added? not needed
Fixed tickets
License MIT

Description

In bower the directory src is ignored. That makes the sass part of medium not usable when loaded with bower.

@j0k3r
Copy link
Contributor

j0k3r commented May 9, 2017

It has been done in purpose: #697

@gsouf
Copy link
Contributor Author

gsouf commented May 9, 2017

Ok thank you. However it forces me to load medium with npm to have access to sass.

Working with foundation-site the sass in available in bower and it's very good.

I cannot say if it's a good idea or not but in my case it forces me to mix front dependencies in both of packages.json and bower.json

@j0k3r
Copy link
Contributor

j0k3r commented May 9, 2017

Seems legit, thanks 🙂

@j0k3r j0k3r merged commit 2fc300c into yabwe:master May 9, 2017
@gsouf
Copy link
Contributor Author

gsouf commented May 9, 2017

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants