Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add label-checkbox relation in CreateLink form #1275 #1340

Merged
merged 1 commit into from
Jun 26, 2017

Conversation

jamenamcinteer
Copy link
Contributor

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
New tests added? not needed
Fixed tickets #1275
License MIT

Description

Added id to anchor target checkbox using this.getEditorId() for
uniqueness, and then added the for attribute to the label

--

Please, don't submit /dist files with your PR!

Added id to anchor target checkbox using this.getEditorId() for
uniqueness, and then added the for attribute to the label
@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.8% when pulling 441766c on ndjamenamarmon:medium-editor#1275 into 2fc300c on yabwe:master.

Copy link
Contributor

@j0k3r j0k3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks

@j0k3r j0k3r merged commit ac28fa4 into yabwe:master Jun 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants