Do not check only for null targets or it will fail when it's undefined. #1373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes Unknown when pulling 293db5e on bago2k4:anchor-no-preview-fix into ** on yabwe:master**. |
|
What are the chances i can have this merged and released any time soon? |
rishijain
approved these changes
Sep 28, 2017
|
Thanks for the fix @bago2k4 👍 |
|
👍 thanks. is a new release going to be cut any time soon? |
|
A lot of build fails on saucelabs, it could be great to fix them before cutting a new release (even if they are failing since a long time). |
|
I'll give it a shot and dig in a little later today |
|
I have a few fixed, potentially. Haven't run Edge, but will open a PR soon. edit: #1396 |
|
Awesome, tests are green again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In version 5.23.2 (and before, not sure from when) if you add a link with
data-disable-previewit triggers an error when youmouseoutit.Here is a jsfiddle that repeat the issue. it pulls in medium-editor 5.23.2 from jscdn.
http://jsfiddle.net/92req5br/