Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When disableEditing is true, enable editing via toolbars. #1403

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tleewu
Copy link

@tleewu tleewu commented Jan 5, 2018

Q A
Bug fix? yes
New feature? yes
BC breaks? no
Deprecations? no
New tests added? yes/not needed
Fixed tickets comma-separated list of tickets fixed by the PR, if any
License MIT

Inspired by #1084

Description

Currently, when disableEditing: true and when you highlight a piece of text, you can see the Medium toolbar, but clicking on the buttons doesn't change the text since contenteditable=false.

image

Fix: allow toolbar editing when disable editing

medium-editing

This is my first time contributing to this repo - would love to hear your thoughts and suggestions!

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 94.285% when pulling 865c238 on tleewu:enable-toolbar-editing-when-edit-disabled into eef3ee0 on yabwe:master.

@tleewu
Copy link
Author

tleewu commented Jan 16, 2018

@nmielnik could you perhaps take a look at this PR and let me know if this is a feasible merge?

@harsharora04
Copy link

This should be pushed live by now?

@MethDamon
Copy link

Hey whats the update on this this is exactly what I need in my application

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants