Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CJK IME input caused duplicated first char issue. #1492

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ulion
Copy link

@ulion ulion commented Mar 3, 2019

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
New tests added? not needed
Fixed tickets #1485
License MIT

Description

When do with CJK IME, the keyUp event should not trigger formatBlock, which will result wrong text in the input (with the extra first char there).
According to https://developer.mozilla.org/en-US/docs/Web/Events/keyup the event can be judged for the IME input composing cases, so made this PR.

--

Please, don't submit /dist files with your PR!

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 94.037% when pulling 0762aaf on ulion:fix_cjk_ime into 9156a11 on yabwe:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants