Skip to content

Conversation

@cshaines
Copy link

@cshaines cshaines commented Feb 7, 2023

Description

This adds Test Support library.
This only works for Swift. The Obj-C support is via the macros in FeatureTestSupport.h which I am guessing requires another target, but I am not sure how this should work since there is no actual Obj-C code.

Motivation and Context

We use the Test Support a lot in our tests and not having this was preventing us from migrating to SPM.

How Has This Been Tested?

I can now build tests that make use of withFeature/withFeatures

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

License

I confirm that this contribution is made under an MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.

@stury stury merged commit ace7f98 into yahoo:master Oct 30, 2023
dbgrandi added a commit that referenced this pull request Jan 3, 2024
While SPM support was added back in #32, it did not include a definition
for the YMOverrideTestSupport library. This is pretty useful for those
who like to add tests around the state of feature flags.

@cshaines updated the SPM manifest in #40, but we never published a new
release. Bump the version to 2.6.0, then we can tag and publish to both
CocoaPods and SPM.
@dbgrandi dbgrandi mentioned this pull request Jan 3, 2024
9 tasks
dbgrandi added a commit that referenced this pull request Jan 3, 2024
While SPM support was added back in #32, it did not include a definition
for the YMOverrideTestSupport library. This is pretty useful for those
who like to add tests around the state of feature flags.

@cshaines updated the SPM manifest in #40, but we never published a new
release. Bump the version to 2.6.0, then we can tag and publish to both
CocoaPods and SPM.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants