Use more restrictive non-escaped character set, per RFC 5849 Section 3.6 #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Sorry for the delay. I spent a very long time carefully pouring over the RFC 5849 when I rewrote this in Swift. Because your PR pertains to the RFC, I wanted to wait until I had enough spare cycles to read it very carefully. That said, the is valid and your change looks correct. I must have missed this one and copied this old code over to the new branch... Thanks so much for taking the time to submit this. |
|
Tests pass |
adamkaplan
approved these changes
Aug 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use more restrictive non-escaped character set, per OAuth Spec (RFC 5849 Section 3.6)
https://datatracker.ietf.org/doc/html/rfc5849#section-3.6
Motivation: \n should be percent encoded. Rather than keep battling this (ala #23), here's a PR that I think is literally what the OAuth spec demands for URL encoding characters that aren't a-z, A-z, 0-9, and the reserved characters:
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.