Skip to content
This repository has been archived by the owner on Apr 30, 2019. It is now read-only.

BOOKKEEPER-1067: Add Prometheus stats provider #7

Merged

Conversation

merlimat
Copy link
Collaborator

Backporting from apache master branch to enable Prometheus in Pulsar bookies as well.


Prometheus (https://prometheus.io) is a metrics collection system, similar but much more flexible than graphite.

It would be good to expose the Bookie and BookKeeper client stats directly so that a Prometheus instance can collect them (and also check the process status and add alerts).

Author: Matteo Merli mmerli@apache.org

Reviewers: Enrico Olivelli eolivelli@gmail.com, Sijie Guo sijie@apache.org

Closes apache#154 from merlimat/prometheus

Prometheus (https://prometheus.io) is a metrics collection system, similar but much more flexible than graphite.

It would be good to expose the Bookie and BookKeeper client stats directly so that a Prometheus instance can collect them (and also check the process status and add alerts).

Author: Matteo Merli <mmerli@apache.org>

Reviewers: Enrico Olivelli <eolivelli@gmail.com>, Sijie Guo <sijie@apache.org>

Closes apache#154 from merlimat/prometheus
Copy link

@saandrews saandrews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Don't we have to add the option to choose the stats provider?

Don't we also have to add documentation on how users will be able to set it up?

@merlimat
Copy link
Collaborator Author

merlimat commented Jun 8, 2017

@saandrews This change was already merged in BK master branch. The documentation on how to use it should be added on BookKeeper, and Pulsar as well.

@merlimat
Copy link
Collaborator Author

merlimat commented Jun 8, 2017

BookKeeper

...on BookKeeper website

@rdhabalia rdhabalia merged commit ed0346c into YahooArchive:yahoo-4.3 Jun 16, 2017
revans2 pushed a commit that referenced this pull request Jun 21, 2017
Prometheus (https://prometheus.io) is a metrics collection system, similar but much more flexible than graphite.

It would be good to expose the Bookie and BookKeeper client stats directly so that a Prometheus instance can collect them (and also check the process status and add alerts).

Author: Matteo Merli <mmerli@apache.org>

Reviewers: Enrico Olivelli <eolivelli@gmail.com>, Sijie Guo <sijie@apache.org>

Closes apache#154 from merlimat/prometheus
rdhabalia pushed a commit to rdhabalia/bookkeeper that referenced this pull request Sep 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants