Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increment bookkeeper version #486

Merged
merged 2 commits into from
Jun 17, 2017
Merged

increment bookkeeper version #486

merged 2 commits into from
Jun 17, 2017

Conversation

rdhabalia
Copy link
Contributor

Motivation

Upgraded bookkeeper-version with changes:

@merlimat : If you already have PR to add additional configuration for prometheus-stats-provider then please feel free to close this PR.

@rdhabalia rdhabalia added the type/feature The PR added a new feature or issue requested a new feature label Jun 17, 2017
@rdhabalia rdhabalia added this to the 1.18 milestone Jun 17, 2017
@rdhabalia rdhabalia self-assigned this Jun 17, 2017
@merlimat
Copy link
Contributor

merlimat commented Jun 17, 2017

@rdhabalia While you're at it, can you also include the prometheus dependency in the all/pom.xml? This way it gets included in the binary distribution.

@merlimat
Copy link
Contributor

@rdhabalia One more issue. The build is failing with a rocksdb java wrapper issue:

Running TestSuite
/usr/lib/jvm/java-8-oracle/jre/bin/java: symbol lookup error: /tmp/librocksdbjni1935689833567743276.so: undefined symbol: ZSTD_versionNumber

Issue was already solved in rocksdb:
facebook/rocksdb#2280

@rdhabalia
Copy link
Contributor Author

should we increment rocksDb version to 5.3.6?

@merlimat
Copy link
Contributor

@rdhabalia
Copy link
Contributor Author

will update with new bk-version once it will be done.

Copy link
Contributor

@merlimat merlimat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rdhabalia
Copy link
Contributor Author

@merlimat do we have anything else for 1.18, should we release it once this build passes?

@merlimat
Copy link
Contributor

I think we should be good with this

@rdhabalia rdhabalia merged commit c92abef into apache:master Jun 17, 2017
@rdhabalia rdhabalia deleted the bk_version branch June 21, 2017 18:49
hangc0276 added a commit to hangc0276/pulsar that referenced this pull request May 26, 2021
* fix system topic produce protection bug and InnerTopicProtectionTest bug

### Changes
- Add system topic protection for handleProduce. However, there is a bug in pulsar, i will fix it by another PR on Pulsar.
- Fix a bug in InnerTopicProtectionTest.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature The PR added a new feature or issue requested a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants