Address @garyluoex's comments

yahoo · Jun 7, 2017 · 350efed · 350efed
1 parent 98b63c8
commit 350efed
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/...ain/java/com/yahoo/bard/webservice/web/responseprocessors/EtagCacheResponseProcessor.java b/...ain/java/com/yahoo/bard/webservice/web/responseprocessors/EtagCacheResponseProcessor.java
@@ -94,7 +94,7 @@ public void processResponse(JsonNode json, DruidAggregationQuery<?> druidQuery,
         } else if (statusCode == Status.OK.getStatusCode()) { // If response is a OK, cache it, including etag
             // make sure JSON response comes with etag
             if (!json.has(DruidJsonResponseContentKeys.ETAG.getName())) {
-                logAndGetErrorCallback(ErrorMessageFormat.ETAG_MISSING_FROM_RESPONSE.format(), druidQuery);
+                LOG.warn(ErrorMessageFormat.ETAG_MISSING_FROM_RESPONSE.format());
             } else {
                 try {
                     dataCache.set(

diff --git a/...vy/com/yahoo/bard/webservice/web/responseprocessors/EtagCacheResponseProcessorSpec.groovy b/...vy/com/yahoo/bard/webservice/web/responseprocessors/EtagCacheResponseProcessorSpec.groovy
@@ -15,6 +15,8 @@ import com.fasterxml.jackson.databind.JsonNode
 import com.fasterxml.jackson.databind.ObjectMapper
 import com.fasterxml.jackson.datatype.jdk8.Jdk8Module
 
+import org.slf4j.Logger
+
 import spock.lang.Specification
 
 class EtagCacheResponseProcessorSpec extends Specification {
@@ -83,11 +85,6 @@ class EtagCacheResponseProcessorSpec extends Specification {
         etagCacheResponseProcessor.processResponse(json, druidAggregationQuery, Mock(LoggingContext))
 
         then:
-        1 * httpErrorCallback.dispatch(
-                INTERNAL_SERVER_ERROR_STATUS_CODE,
-                ErrorMessageFormat.INTERNAL_SERVER_ERROR_REASON_PHRASE.format(),
-                ErrorMessageFormat.ETAG_MISSING_FROM_RESPONSE.format()
-        )
         1 * next.processResponse(null, druidAggregationQuery, _ as LoggingContext)
     }