Skip to content

Commit

Permalink
Fixes a few useless injection points.
Browse files Browse the repository at this point in the history
--The original return type of
`AbstractBinderFactory::buildDruidQueryBuilder` and
`AbstractBinderFactory::buildDruidResponeParser` did not allow returning a
subtype of `DruidQueryBuilder` because template types are much more
rigid than standard Java types by default.
  • Loading branch information
Andrew Cholewa committed Nov 16, 2016
1 parent 2d39299 commit fff5f2b
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,10 @@ Current

### Fixed:

- [Made a few injection points not useless](https://github.com/yahoo/fili/pull/98)
* Template types don't get the same subclass goodness that method invocation and
dependencies get, so this method did not allow returning a subclass of
`DruidQueryBuilder` or of `DruidResponseParser`.


### Known Issues:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -334,7 +334,7 @@ protected void configure() {
*
* @return An isntance of the {@link DruidQueryBuilder}
*/
protected Class<DruidQueryBuilder> buildDruidQueryBuilder() {
protected Class<? extends DruidQueryBuilder> buildDruidQueryBuilder() {
return DruidQueryBuilder.class;
}

Expand All @@ -343,7 +343,7 @@ protected Class<DruidQueryBuilder> buildDruidQueryBuilder() {
*
* @return An instance of the {@link DruidResponseParser}
*/
protected Class<DruidResponseParser> buildDruidResponseParser() {
protected Class<? extends DruidResponseParser> buildDruidResponseParser() {
return DruidResponseParser.class;
}

Expand Down

0 comments on commit fff5f2b

Please sign in to comment.