Disjoint request intervals prevents CSV-formatted responses from returning correctly

[cdeszaq]

I've not dug into it, but requests with multiple disjoint intervals specified (like 2016-10-08/2016-10-09,2016-10-11/2016-10-12) and a CSV formatted response (ie. format=csv) cause Fili's response to be unfriendly to browsers.

I've not tried it in a non-browser environment like curl yet, but I wanted to raise a flag so that others are aware of the problem. I think @mangesh-pardeshi ran into the issue first, and so he may be looking into it, but I'm not sure.

[mangesh-pardeshi]

Yes, I ran into this issue and will look in to it. Currently working on #72

[mangesh-pardeshi]

works fine with curl

[cdeszaq]

@mangesh-pardeshi what does curl give as raw output? (ie. curl -vv to show all the headers, etc.) My guess is that there's a mismatch between the Content-Type header and what we're sending in the response (possibly)

[mangesh-pardeshi]

GET /v1/data/network/all/?dateTime=2016-10-08/2016-10-09,2016-10-11/2016-10-12&metrics=dayAvgUniqueIdentifier&format=csv HTTP/1.1
< HTTP/1.1 200 OK
< Content-Type: text/csv; charset=utf-8
< Content-Disposition: attachment; filename=data-network-all-_2016-10-08_2016-10-09,2016-10-11_2016-10-12.csv
< Access-Control-Allow-Origin: *
< Access-Control-Allow-Methods: *
< Access-Control-Allow-Credentials: true
< Content-Length: 104

Browser request generates NPL. Looking into it

[mangesh-pardeshi]

Surprisingly it also fails using Postman when I am explicitly passing Content-type=text/csv and Accept=/

[cdeszaq]

Based on the verbose curl output, it looks like only the response headers are getting sent, and the csv response body is failing to send. The Content-Length of only 104 bytes is very suspicious. Given that, I'm not surprised clients get upset, since they are not getting any actual content back.

I'm guessing there'll be dumps in the logs from something failing to build the csv body. We just are not seeing the failure in the response because the headers are already sent.

[cdeszaq]

Fixed by #76