Change csv attachment name to use '__' instead of ',' #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 Looks fine to me once there's a changelog entry. @codingwhatever, you guys pushed for having better download file names initially, right? Since this is a fix to otherwise broken functionality, I'm guessing this change is fine, but I wanted to ping you just in case 😉 |
mangesh-pardeshi
force-pushed
the
changeContentDipositionHeader
branch
from
edfaa1a to
6477326
Compare
|
👍 |
|
👍 This should be fine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chrome does not accept ',' as part of the filename so changing it to use '__' instead.