Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull request objects out of apiRequest and push request context to response building code. #711

Open
michael-mclawhorn opened this issue Jun 6, 2018 · 2 comments

Comments

@michael-mclawhorn
Copy link
Contributor

This is a nice precursor to support:
#709

However the greater motivation is to push less of the response building state via apiRequest and more via injection/invocations of the response building code. Keep the jersey code at the response writing layer.

@michael-mclawhorn
Copy link
Contributor Author

This cleans up a longstanding conceptual piece of pain by isolating the ApiRequest objects from the mechanics of response building. In the event that ApiRequests were being used in a non Jersey container, this would be a critical function for supporting that.

Worth considering is going one level further and taking the ResponseFormat object out of the ApiRequest. It's debatable that there might be cases where the response format would inform query optimizations, so that change may be premature.

@cdeszaq
Copy link
Collaborator

cdeszaq commented Jun 7, 2018

Always a good idea to keep layers separated. I'm a fan of keeping the "this is in service of an HTTP request / response" out of the business logic where we can, but agree that the notion of "response format" may be useful, from an optimization standpoint. At the very least, it can always get extracted later, so no need to increase the scope of this issue with it right now.

michael-mclawhorn added a commit that referenced this issue Jul 24, 2018
…m impl](#711)

- [Restructured Report Building out of ApiRequest](#711)
- [Undeprecated pagination by collection](#711)
michael-mclawhorn added a commit that referenced this issue Jul 24, 2018
…m impl](#711)

- [Restructured Report Building out of ApiRequest](#711)
- [Undeprecated pagination by collection](#711)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants