Have TablesApiRequest Support Additional Query Parameters #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QubitPi
force-pushed
the
getLogicalTableFullView-with-TablesApiRequest
branch
2 times, most recently
from
6bbe39d to
75782d5
Compare
michael-mclawhorn
requested changes
Jul 21, 2017
| @@ -368,7 +368,12 @@ public Response getTablesFullView( | |||
| * @param uriInfo UriInfo of the request | |||
| * | |||
| * @return Full view of the logical table | |||
| * | |||
| * @deprecated Inorder to display constrained data availability in table resource, this method needs to accept a | |||
There was a problem hiding this comment.
spelling -> In order
QubitPi
force-pushed
the
getLogicalTableFullView-with-TablesApiRequest
branch
from
1c0561e to
9e2a0e2
Compare
|
@michael-mclawhorn I moved some methods from |
dayamr
approved these changes
Jul 24, 2017
| - [Fili-security module](https://github.com/yahoo/fili/pull/405) | ||
| * Added security module for fili data security filters | ||
| * Created `ChainingRequestMapper`, and a set of mappers for gatekeeping on security roles and whitelisting dimension filters. | ||
| * Created `ChainingRequestMapper`, and a set of mappers for gatekeeping on security roles and whitelisting dimension filters. | ||
|
|
||
| - [Add Table-wide Availability](https://github.com/yahoo/fili/pull/414) | ||
| * Add `availableIntervals` field to tables endpoint by union the availability for the logical table without taking |
There was a problem hiding this comment.
Add additional points about moving the methods from DataApiRequest to `ApiRequest'
There was a problem hiding this comment.
It would be nice to explain the scope of this PR since it is not the complete feature implementation. Otherwise changes looks good.
QubitPi
force-pushed
the
getLogicalTableFullView-with-TablesApiRequest
branch
from
c9b578c to
04eff7e
Compare
michael-mclawhorn
approved these changes
Aug 2, 2017
QubitPi
force-pushed
the
getLogicalTableFullView-with-TablesApiRequest
branch
from
02517a8 to
c3ecb49
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 2nd milestone of #310