Use all available segment metadata for fili-generic-example #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-mclawhorn
approved these changes
Jul 28, 2017
garyluoex
approved these changes
Aug 14, 2017
| @@ -34,14 +37,14 @@ | |||
| * | |||
| * @return a list of names of metrics for the current datasource. | |||
| @@ -34,14 +37,14 @@ | |||
| * | |||
| * @return a list of names of metrics for the current datasource. | |||
| */ | |||
| List<String> getMetrics(); | |||
| Set<String> getMetrics(); | |||
|
|
|||
| /** | |||
| * Gets the names of all the dimensions for the current datasource. | |||
| * | |||
| * @return a list of names of dimensions for the current datasource. | |||
- The fili-generic-example was previously only using the first segment but it may as well use all - This also provides these segments to the MetadataService
kevinhinterlong
force-pushed
the
fixGenericExample
branch
from
31158bf to
b6c2916
Compare
kevinhinterlong
added
MERGEABLE
and removed
NEED 1 REVIEW
NEED REBASE
REVIEWABLE
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fili-generic-examplewas previously only using the first segment in the response from Druid but it may as well use all of themAddresses #428