Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Utils.makeImmutable in favor of Guava #479

Merged
merged 3 commits into from
Aug 10, 2017

Conversation

kevinhinterlong
Copy link
Member

Addresses #353

@yahoo yahoo deleted a comment Aug 2, 2017
@yahoo yahoo deleted a comment Aug 2, 2017
@yahoo yahoo deleted a comment Aug 2, 2017
Copy link
Contributor

@michael-mclawhorn michael-mclawhorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is ok. I'm not 100% sure about Guava immutables, but our custom solution shouldn't be used.

@yahoo yahoo deleted a comment Aug 10, 2017
@garyluoex garyluoex merged commit c31d808 into yahoo:master Aug 10, 2017
@kevinhinterlong kevinhinterlong deleted the refactorCoreUtils branch August 10, 2017 22:28
saiyan86 pushed a commit to saiyan86/fili that referenced this pull request Aug 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants