added constructor and wither for tables api request #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
archolewa
approved these changes
Sep 22, 2017
| // CHECKSTYLE:OFF | ||
| public TablesApiRequest withFormat(ResponseFormatType format) { | ||
| return new TablesApiRequest(format, paginationParameters, uriInfo, builder, | ||
| tables, table, granularity, dimensions, metrics, intervals, filters); |
There was a problem hiding this comment.
Since we're turning checkstyle off anyway, we might as well move all of this onto one line to line up with how we do the other withers.
|
Addressed the comments |
|
👍 |
|
That failure is from a flaky test. I'll try to deactivate it soon. In the mean time, get @QubitPi 's rereview and then merge |
QubitPi
suggested changes
Sep 22, 2017
| @@ -222,6 +225,43 @@ public TablesApiRequest( | |||
| } | |||
|
|
|||
| /** | |||
| * All argument constructor for withers. | |||
| * @param format response data format JSON or CSV. Default is JSON. | |||
| @@ -222,6 +225,43 @@ public TablesApiRequest( | |||
| } | |||
|
|
|||
| /** | |||
| * All argument constructor for withers. | |||
| * @param format response data format JSON or CSV. Default is JSON. | |||
| * @param dimensions Grouping dimensions / Dimension constraint | ||
| * @param metrics Metrics constraint | ||
| * @param intervals Data / Time constraint | ||
| * @param filters Filter constraint |
There was a problem hiding this comment.
General - Capitalize first words in description.
| * @param intervals Data / Time constraint | ||
| * @param filters Filter constraint | ||
| */ | ||
| private TablesApiRequest( |
There was a problem hiding this comment.
Why are we making this private?
Why do we want an all-args constructor?
It would be nice to explain in change log as well as in JavaDoc of this constructor
|
addressed all the comments |
|
@QubitPi can you review it again ? |
asifmansoora
force-pushed
the
constructor-and-wither-for-tablesApiRequest
branch
from
ae6abb3 to
1ca8a1a
Compare
asifmansoora
force-pushed
the
constructor-and-wither-for-tablesApiRequest
branch
from
1ca8a1a to
b56ac75
Compare
asifmansoora
force-pushed
the
constructor-and-wither-for-tablesApiRequest
branch
from
b56ac75 to
e3de13b
Compare
QubitPi
approved these changes
Sep 25, 2017
asifmansoora
deleted the
constructor-and-wither-for-tablesApiRequest
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TablesApiRequest was missing an all argument constructor and withers