revert the druid name and add it to fact name in slices endpoint #541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asifmansoora
force-pushed
the
reverting-druid-name-on-slices-servlet
branch
from
0241854 to
33a72a8
Compare
asifmansoora
force-pushed
the
reverting-druid-name-on-slices-servlet
branch
from
33a72a8 to
2e21a8a
Compare
michael-mclawhorn
approved these changes
Sep 22, 2017
QubitPi
suggested changes
Sep 25, 2017
CHANGELOG.md
Outdated
| @@ -168,6 +168,9 @@ Current | |||
|
|
|||
| ### Removed: | |||
|
|
|||
| - [Reverted the druid name change in slices endpoint instead added to factName](https://github.com/yahoo/fili/pull/541) | |||
| * Reverting this PR #491 so that the name still points to apiName and added factName which points to druidName. | |||
There was a problem hiding this comment.
Adding link to #491 makes it better
In addition, it makes more sense to talk about the reason for this roll back as well as factName
| @@ -179,7 +179,8 @@ protected SlicesApiRequest() { | |||
| Column key = e.getKey(); | |||
| if (key instanceof DimensionColumn) { | |||
| Dimension dimension = ((DimensionColumn) key).getDimension(); | |||
| row.put("name", table.getPhysicalColumnName(dimension.getApiName())); | |||
| row.put("name", dimension.getApiName()); | |||
| row.put("factName", table.getPhysicalColumnName(dimension.getApiName())); | |||
There was a problem hiding this comment.
dimension.getApiName() to a variable since it's used twice
| if (it.key instanceof DimensionColumn) { | ||
| row["uri"] = uri + it.key.name | ||
| row["factName"] = table.getPhysicalColumnName(it.key.name) |
There was a problem hiding this comment.
Just curious, why are we putting this inside a conditional?
There was a problem hiding this comment.
Because factName was valid only for dimension rows
asifmansoora
force-pushed
the
reverting-druid-name-on-slices-servlet
branch
from
2e21a8a to
6645068
Compare
QubitPi
approved these changes
Sep 25, 2017
CHANGELOG.md
Outdated
| @@ -172,7 +172,9 @@ Current | |||
| ### Removed: | |||
|
|
|||
| - [Reverted the druid name change in slices endpoint instead added to factName](https://github.com/yahoo/fili/pull/541) | |||
| * Reverting this PR #491 so that the name still points to apiName and added factName which points to druidName. | |||
| * Reverting the PR-419(https://github.com/yahoo/fili/pull/419) so that the name still points to apiName and added factName which points to druidName. | |||
| `name` was not valid for cases when its a Lookup dimension because it was pointing to the base dimension name , so reverted that change and added | |||
asifmansoora
force-pushed
the
reverting-druid-name-on-slices-servlet
branch
from
6645068 to
06bfa3d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverting this PR #491 so that the
namestill points toapiNameand addedfactNamewhich points todruidName